[PATCH] D72601: GlobalISel: Lower G_WRITE_REGISTER

Mon Jan 27 06:31:12 PST 2020

arsenm marked an inline comment as done.
arsenm added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/write_register.ll:2
+; Runs original SDAG test with -global-isel
+; RUN: llc -global-isel -march=amdgcn -mcpu=bonaire -enable-misched=0 -verify-machineinstrs < %S/../write_register.ll | FileCheck -enable-var-scope %S/../write_register.ll
----------------
aemerson wrote:
> I don't know how I feel about this. Perhaps just add an extra run line to the existing test?
> 
> Since you're removing something from arm64 fallback, could you add a small test for arm64 as well?
This is how all of the other tests I've been sharing do it. I'm not sure I want to start leaking global isel run lines into the general test population

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72601/new/

https://reviews.llvm.org/D72601