[PATCH] D73275: [ARM][LowOverheadLoops] Don't ignore VCTP

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks like a straightforward fix to me.



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:906
       SmallPtrSet<MachineInstr*, 4> Remove;
       SmallPtrSet<MachineInstr*, 4> Ignore = { LoLoop.Start, LoLoop.Dec,
+                                               LoLoop.End, LoLoop.InsertPt };
----------------
nit: you can ignore this remark, but perhaps time to rename `Ignore` to something 'scarier' such as `UnsafeToRemove` (the variable is called `Ignore`, but the test file `dont-ignore-vctp.mir`, if you see what I mean).


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/dont-ignore-vctp.mir:5
+--- |
+  define hidden arm_aapcs_vfpcc void @arm_cmplx_conj_f32_mve(float* %pSrc, float* %pDst, i32 %blockSize) local_unnamed_addr #0 {
+  entry:
----------------
nit: don't think it matters in this case, but perhaps rename the function name


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73275/new/

https://reviews.llvm.org/D73275