[PATCH] D72562: [Attributor][Fix] AAHeapToStack and AAIsDead connection

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 02:00:21 PST 2020


sstefan1 added a comment.

In D72562#1837865 <https://reviews.llvm.org/D72562#1837865>, @jdoerfert wrote:

> This needs to be integrated with D73313 <https://reviews.llvm.org/D73313>.


I think there is no integration with D73313 <https://reviews.llvm.org/D73313> since I only need to change `AAIsDeadFunction::IsAssumedDead`. If that is correct I think this doesn't depend on D73313 <https://reviews.llvm.org/D73313>.

Also, I'll drop the changes to the existing interfaces, e.g. `CheckForAllXXX`.

In D72562#1837865 <https://reviews.llvm.org/D72562#1837865>, @jdoerfert wrote:

> I suggest we ask H2M if we have a call explicitly if it assumes to remove it.


That is kind of the current implementation, but I'll change it a bit so the changes to existing interfaces are not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72562/new/

https://reviews.llvm.org/D72562





More information about the llvm-commits mailing list