[PATCH] D72962: [MLIR, OpenMP] Translation of OpenMP barrier construct to LLVM IR

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan marked 6 inline comments as done.
kiranchandramohan added inline comments.


================
Comment at: mlir/include/mlir/Target/LLVMIR/ModuleTranslation.h:29
+
+extern llvm::cl::opt<bool> enableOpenMP;
 
----------------
mehdi_amini wrote:
> cl::opt are only intended for testing, I wouldn't expect it in library code.
The cl::opt flag is now only visible in mlir/lib/Target/LLVMIR/ModuleTranslation.cpp. Is that what you suggested?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72962/new/

https://reviews.llvm.org/D72962