[PATCH] D72992: [llvm-objdump] - Add column headers for relocation printing

Mon Jan 27 01:43:32 PST 2020

grimar added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/relocations-elf.test:191
+- Name: .rela.text
+  Type: SHT_RELA
+  Link: .symtab
----------------
jhenderson wrote:
> jhenderson wrote:
> > grimar wrote:
> > > grimar wrote:
> > > > It is strange to see `SHT_RELA` section in a `ELFCLASS32` object.
> > > > What do you want to check with it? I see it is what the test case above did, but I do not know why it does that :)
> > > (I mean it has `SHT_REL`, what is unnatural for `ELFCLASS64` in the same way like `SHT_RELA` is unnatural for `ELFCLASS32`). 
> > I'd keep both SHT_REL and SHT_RELA sections. The gABI doesn't limit these sections to architectures of one or other size (although some processor supplements do), so we should show we can handle all situations. I know at least one system I worked on used SHT_REL originally and then later swapped to SHT_RELA.
> @grimar, are you happy with my suggestion of keeping both?
Ah, yes, sorry for not adding an explicit comment about it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72992/new/

https://reviews.llvm.org/D72992