[PATCH] D73416: [mlir][spirv] Create builtin variable in nearest symbol table

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked an inline comment as done.
antiagainst added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp:235
+  Operation *parent = op->getParentOp();
+  while (parent && !parent->hasTrait<OpTrait::SymbolTable>())
+    parent = parent->getParentOp();
----------------
rriddle wrote:
> SymbolTable.cpp defines a static method for this(getNearestSymbolTable) that we could likely expose.
Good point! https://reviews.llvm.org/D73433


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73416/new/

https://reviews.llvm.org/D73416