[PATCH] D70759: [llvm-symbolizer] Support debug file lookup using build ID

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a subscriber: lhames.
dblaikie added inline comments.


================
Comment at: llvm/lib/DebugInfo/Symbolize/Symbolize.cpp:303
+        return N.getDesc();
+  }
+  return {};
----------------
vsk wrote:
> Does `Err` need to be checked here, after the loop?
> 
> From `notes_begin`:
> 
>   /// \param Err [out] an error to support fallible iteration, which should
>   ///  be checked after iteration ends.
> 
Looks like it to me.

A test case would be good/necessary, though - @lhames - you wouldn't happen to know a good way to produce an object file with this problem, by chance?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70759/new/

https://reviews.llvm.org/D70759