[PATCH] D73292: [AMDGPU] Correct NumLoads in clustering

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 12:27:28 PST 2020


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM! Perhaps add a comment in TargetInstrInfo.h documenting the argument? E.g. "the number of loads that will be in the cluster if this hook returns true"...?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73292/new/

https://reviews.llvm.org/D73292





More information about the llvm-commits mailing list