[PATCH] D72467: Remove "mask" operand from shufflevector.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 10:42:02 PST 2020


spatel added a comment.

In D72467#1839172 <https://reviews.llvm.org/D72467#1839172>, @efriedma wrote:

> In D72467#1838591 <https://reviews.llvm.org/D72467#1838591>, @spatel wrote:
>
> > LGTM, but should get a 2nd opinion since I'm not familiar with some of the parts.
>
>
> Any specific part you're worried about?


I don't know anything about the scalable vector enhancements, but that seems covered now. Nuances of the bitcode serialization are beyond me, but I trust you've stepped through that. So, no worries. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72467/new/

https://reviews.llvm.org/D72467





More information about the llvm-commits mailing list