[PATCH] D73381: [PGO][PGSO] Handle MBFIWrapper

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 13:50:10 PST 2020


yamauchi created this revision.
yamauchi added a reviewer: davidxl.
Herald added subscribers: hiraditya, mgorny.
Herald added a project: LLVM.

Some code gen passes use MBFIWrapper to keep track of the frequency of new
blocks. This was not taken into account and could lead to incorrect frequencies
as MBFI silently returns zero frequency for unknown/new blocks.

Add a variant for MBFIWrapper in the PGSO query interface.

Move MBFIWrapper from BranchFolding to independent files to solve the header
file dependency cycle issue.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73381

Files:
  llvm/include/llvm/CodeGen/MBFIWrapper.h
  llvm/include/llvm/CodeGen/MachineSizeOpts.h
  llvm/include/llvm/CodeGen/TailDuplicator.h
  llvm/include/llvm/Transforms/Utils/SizeOpts.h
  llvm/lib/CodeGen/BranchFolding.cpp
  llvm/lib/CodeGen/BranchFolding.h
  llvm/lib/CodeGen/CMakeLists.txt
  llvm/lib/CodeGen/IfConversion.cpp
  llvm/lib/CodeGen/MBFIWrapper.cpp
  llvm/lib/CodeGen/MachineBlockPlacement.cpp
  llvm/lib/CodeGen/MachineSizeOpts.cpp
  llvm/lib/CodeGen/TailDuplication.cpp
  llvm/lib/CodeGen/TailDuplicator.cpp
  llvm/test/CodeGen/X86/tail-opts.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73381.240285.patch
Type: text/x-patch
Size: 22101 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200124/8fbb05c5/attachment.bin>


More information about the llvm-commits mailing list