[PATCH] D73294: [GWP-ASan] enable/disable and fork support.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 13:31:58 PST 2020


eugenis marked an inline comment as done.
eugenis added inline comments.


================
Comment at: compiler-rt/lib/gwp_asan/tests/enable_disable.cpp:51
+  pthread_mutex_lock(&Mutex);
+  ThreadReady = true;
+  pthread_cond_signal(&Conditional);
----------------
hctim wrote:
> I don't see why this value is needed - we don't expect someone else to send the cond_signal for this conditional, right?
pthread_cond_wait is allowed spurious wake ups.
Using it without a loop with an external condition is almost always wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73294/new/

https://reviews.llvm.org/D73294





More information about the llvm-commits mailing list