[PATCH] D73373: [GWP-ASan] Add names to anonymous mappings.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 13:23:04 PST 2020


hctim added a comment.

> AFAIK we do test on android.

`compiler-rt/cmake/config-ix.cmake:739`

  # Note: Fuchsia and Windows are not currently supported by GWP-ASan. Support
  # is planned for these platforms. Darwin is also not supported due to TLS
  # calling malloc on first use.
  # TODO(hctim): Enable this on Android again. Looks like it's causing a SIGSEGV
  # for Scudo and GWP-ASan, further testing needed.
  if (COMPILER_RT_HAS_SANITIZER_COMMON AND GWP_ASAN_SUPPORTED_ARCH AND
      OS_NAME MATCHES "Linux") # <----------------------------------------------------------------------------[here]
    set(COMPILER_RT_HAS_GWP_ASAN TRUE)
  else()
    set(COMPILER_RT_HAS_GWP_ASAN FALSE)
  endif()
  pythonize_bool(COMPILER_RT_HAS_GWP_ASAN)

I should probably address this TODO as well... It may actually be resolved with the fork() changes, but I can't remember what the exact problem is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73373/new/

https://reviews.llvm.org/D73373





More information about the llvm-commits mailing list