[PATCH] D73374: [msan] Instrument x86.pclmulqdq* intrinsics.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3003
 
+  Constant *getPclmulMask(IRBuilder<> &IRB, unsigned Width, unsigned Imm) {
+    SmallVector<Constant *, 8> Mask;
----------------
Maybe the Imm arg should just be something like "bool OddElements".


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3027
+           "pclmul 3rd operand must be a constant");
+    unsigned Imm = dyn_cast<ConstantInt>(I.getArgOperand(2))->getZExtValue();
+    Value *Shuf0 =
----------------
This should be a cast, not a dyn_cast.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73374/new/

https://reviews.llvm.org/D73374