[PATCH] D73318: Print discriminators when printing .debug_line in GNU style.

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 10:13:31 PST 2020


saugustine added a comment.

In D73318#1838181 <https://reviews.llvm.org/D73318#1838181>, @jhenderson wrote:

> Is there a particular reason to restrict this to GNU style? I think it's okay to expand on the LLVM style too, but might be worth getting more opinions on it.


LLVM output style already prints the column number (file:line:column), which tells you the same thing as the discriminator, but at a higher level that is more friendly for users. I'm open to adding it, but it seems a bit redundant.

Otherwise updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73318/new/

https://reviews.llvm.org/D73318





More information about the llvm-commits mailing list