[PATCH] D73107: [llvm-objcopy][COFF] Add support for --set-section-flags

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:143
+
+ Following is a list of flag effects on ELF objects:
+
----------------
I'd probably rephrase this as follows:

"For ELF objects, the flags have the following effects:"

I'd also rephrase the COFF one similarly.


================
Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:158
+
+ - `alloc` = add `IMAGE_SCN_CNT_UNINITIALIZED_DATA` and `IMAGE_SCN_MEM_READ`
+   flags, unless `load` flag is specified.
----------------
add -> add the

Here and on each subsequent line starting with "add".


================
Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:159
+ - `alloc` = add `IMAGE_SCN_CNT_UNINITIALIZED_DATA` and `IMAGE_SCN_MEM_READ`
+   flags, unless `load` flag is specified.
+ - `noload` = add `IMAGE_SCN_LNK_REMOVE` and `IMAGE_SCN_MEM_READ` flags.
----------------
unless -> unless the


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73107/new/

https://reviews.llvm.org/D73107