[PATCH] D73044: {tablegen] Emit string literals instead of char arrays

[Luke Drummond via Phabricator via llvm-commits]

ldrumm marked an inline comment as done.
ldrumm added inline comments.


================
Comment at: llvm/cmake/modules/TableGen.cmake:66
+  # [1] https://docs.microsoft.com/en-us/cpp/cpp/compiler-limits?view=vs-2017
+  if (MSVC AND project STREQUAL LLVM)
+    list(APPEND LLVM_TABLEGEN_FLAGS "--long-string-literals=0")
----------------
rnk wrote:
> This works for now, but I just recently I wanted to use SequenceToOffsetTable in clang, but I used StringToOffsetTable.h instead. So far our such tables are small enough not to cause problems, but eventually we probably want to move this thing to the TableGen library, etc, etc. Anyway, this is not a blocking concern.
> f63d7637387995765e9ece0e10fe1b5a4f0612b5
Sounds good. I'm happy to revisit this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73044/new/

https://reviews.llvm.org/D73044