[PATCH] D73107: [llvm-objcopy][COFF] Add support for --set-section-flags

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-objcopy.rst:409
 
 .. option:: --set-section-flags <section>=<flag>[,<flag>,...]
 
----------------
sdmitriev wrote:
> jhenderson wrote:
> > This is still under the "ELF-specific Options" section...
> Right. I did not realize that there is a dedicated ELF-specific section. I have added --set-section-flags option description to the COFF-specific section.
I've actually just removed the COFF-specific section (see rG0298a8751152). The normal approach would be to put the whole lot in the generic section (since the switch applies to multiple formats), and put the individual ELF and COFF bits one below the other in the description. See --strip-all for a sort-of example (it explains ELF and then COFF/Mach-O).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73107/new/

https://reviews.llvm.org/D73107