[PATCH] D73193: [llvm-readelf] - Improve dumping of objects without a section header string table.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 03:01:08 PST 2020


grimar marked 2 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/sections-no-section-header-string-table.test:46
+# LLVM-NEXT:   }
+# LLVM-NEXT: error: '[[FILE]]': a section [index 2] has an invalid sh_name (0x1) offset which goes past the end of the section name string table
+
----------------
jhenderson wrote:
> Not directly related to this change, but I'd like to see this changed to a warning at some point. It's annoying that we can't dump the rest of the table in this case, and there's no fundamental reason why we can't.
I fully agree. Will fix.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73193/new/

https://reviews.llvm.org/D73193





More information about the llvm-commits mailing list