[PATCH] D73145: [mlir][Linalg] Add a Linalg DRR test to go from matmul to vectors

JOSE IGNACIO GOMEZ PEREZ via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 02:26:23 PST 2020


tetuante added inline comments.


================
Comment at: mlir/test/Dialect/Linalg/matmul-to-vector.mlir:25
+// CHECK-SAME: iterator_types = ["parallel", "parallel", "reduction"]
+// CHECK-SAME: : vector<8x16xf32>, vector<16x12xf32> into vector<8x12xf32>
----------------
ftynse wrote:
> Could you describe where do this magic sizes come from?
I think they come from 

```
def : Pat<(MatmulOp:$op $_, $_, $_),
          (TileLinalgOp<[8, 12, 16], "L1__with_perm__", [1, 0, 2]>),
         [(Constraint<HasLinalgTransformMarker<"L2__with_perm__">>)]>;
```
in TestLinalgMatmulToVectorPatterns.td

They are fixed tile sizes right now  for testing,  but should somehow be computed in the futre  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73145/new/

https://reviews.llvm.org/D73145





More information about the llvm-commits mailing list