[PATCH] D73075: [utils] Add initial llvm-patch helper to manage patches.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 02:23:53 PST 2020


mstorsjo added a comment.

In D73075#1837867 <https://reviews.llvm.org/D73075#1837867>, @fhahn wrote:

> That’s a bit unfortunate. Maybe it could still warn if there’s a mismatch between committer name and the author on phab.


Yeah, and maybe also fetch and print the original author name and maybe prepopulate the author field like "Real Name <mail at missing>" or something such, with a note to look up the proper email address.

I guess there's two cases where this tool would be used:

- Applying someone else's patch. In that case getting as much info as possible and a reminder to look up what to set in the author field is best
- Applying one's own patch. (This isn't something I'd ever do myself though.) In that case, if the author seems to be oneself, it's best to leave the author field in whichever form it's set up in the local git config.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73075/new/

https://reviews.llvm.org/D73075





More information about the llvm-commits mailing list