[PATCH] D73309: [lsan] Factor pthread-specific assumptions out of thread tracking code

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/lsan/lsan_posix.cpp:31
+struct OnStartedArgs {
+  uptr stack_begin, stack_end,
+       cache_begin, cache_end,
----------------
can you make it more consistent?
type name1;
type name2;
...



================
Comment at: compiler-rt/lib/lsan/lsan_posix.cpp:65
+  ThreadContext *context = static_cast<ThreadContext *>(
+      GetThreadRegistryLocked()->FindThreadContextByOsIDLocked(os_id));
+  if (!context) return false;
----------------
is this clang-formated?


================
Comment at: compiler-rt/lib/lsan/lsan_posix.h:39
+ private:
+  uptr tls_begin_, tls_end_;
+  DTLS *dtls_;
----------------
same about one per line


================
Comment at: compiler-rt/lib/lsan/lsan_thread.h:35
+ protected:
   uptr stack_begin_, stack_end_,
+       cache_begin_, cache_end_;
----------------
maybe here and else
just 
uptr stack_begin_ = 0; 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73309/new/

https://reviews.llvm.org/D73309