[PATCH] D72992: [llvm-objdump] - Add column headers for relocation printing

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 01:09:38 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/relocations-in-nonreloc.test:9
 # RUN: llvm-objdump -r %t3 | FileCheck %s -DFILE=%t3 --check-prefixes=FMT,REL --implicit-check-not={{.}}
+# RUN: llvm-objdump -r %t3 | FileCheck %s -DFILE=%t3 --strict-whitespace --check-prefixes=REL
 
----------------
liadz0rz wrote:
> jhenderson wrote:
> > I'm not sure you need this additional test case here. I don't think it adds anything above the line above.
> Checking strict-whitespaces on FMT kept failing and it didn't really matter on the padding change
Okay. Regardless, there's no need for a --strict-whitespace check here, as @grimar mentioned. We only need --strict-whitespace for the "main" relocations test for a given format (i.e. relocations-elf.test).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72992/new/

https://reviews.llvm.org/D72992





More information about the llvm-commits mailing list