[PATCH] D73174: [llvm-readobj] - Refine --needed-libs implementation and add a test.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 24 00:51:15 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2476
 
-  for (const auto &L : Libs)
+  for (const std::string &L : Libs)
     W.startLine() << L << "\n";
----------------
jhenderson wrote:
> StringRef?
(I think keeping the original type does not hurt.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73174/new/

https://reviews.llvm.org/D73174





More information about the llvm-commits mailing list