[PATCH] D73317: [GISelKnownBits] Add support for PHIs

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 17:56:28 PST 2020


qcolombet marked an inline comment as done.
qcolombet added inline comments.


================
Comment at: llvm/unittests/CodeGen/GlobalISel/GISelMITest.h:111
+    liveins: $x0, $x1, $x2, $x4
+
     %0(s64) = COPY $x0
----------------
In case someone wonders, this change is required to have MIRString with basic blocks that have variables that are live out, otherwise the machine verifier will complain that some variables are not live out of the predecessors when use in a phi.
(Basically we need the tracksRegLiveness property and when we set it, we need to mark as live ins all phys regs that are used across all the GISel tests.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73317/new/

https://reviews.llvm.org/D73317





More information about the llvm-commits mailing list