[PATCH] D73283: Handle complex DWARF expressions in combination with "complex" registers

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 13:43:04 PST 2020


aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:296
+        // because we have a simple expression.
+        unsigned SubRegBits = Reg.SubRegisterSizeInBits;
+        if (BitsEmitted + SubRegBits > FragmentBits)
----------------
One thing I don't like about this myself is that this is a special case of the code in addExpression().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73283/new/

https://reviews.llvm.org/D73283





More information about the llvm-commits mailing list