[PATCH] D73235: [GlobalMerge] Preserve symbol visibility when merging globals

Thu Jan 23 13:43:02 PST 2020

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: llvm/test/CodeGen/AArch64/global-merge-hidden-minsize.ll:18
+; CHECK: .globl y
+; CHECK: .hidden y
----------------
mspang wrote:
> efriedma wrote:
> > Missing CHECK lines to verify the globals were actually merged.
> Added them. I wasn't sure if we needed to, since the command line is not asking for this specific optimization and the bug is just that we end up with wrong visibility. But I think I agree with you, better to fail if this case isn't merged so we can update the test.
Yes, the point of the extra CHECK lines is to ensure the test continues to test the transform in question.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73235/new/

https://reviews.llvm.org/D73235