[PATCH] D71640: [docs] Remove `git llvm push` and `git llvm revert` from GettingStarted

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 10:11:57 PST 2020


bogner marked an inline comment as done.
bogner added inline comments.


================
Comment at: llvm/docs/GettingStarted.rst:494
+Once a patch is reviewed, you should rebase it, re-test locally, and commit the
+changes to LLVM's master branch. This is done using `git push`.
 
----------------
mehdi_amini wrote:
> You're using "commit" in a fairly liberal way. Since we're native Git now, can we adjust the vocabulary?
> 
> ```
> Once a patch is reviewed, you can commit it in your local clone of the repository in the master branch, and use `git push` to push it to the upstream repository on GitHub. You may need to run `git pull --rebase` in case other changes have been pushed in the meantime.
> 
> Note that LLVM currently has a linear-history policy, which means that merge commits are
> not allowed. The `llvm-project` repository on GitHub is configured to reject pushes
> that include merges, so make sure to use `--rebase` when you pull. Alternatively you can
> do once `git config --global pull.rebase true` to make it the default on your system.
> ```
> 
Seems reasonable. Do you want to make this change or shall I?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71640/new/

https://reviews.llvm.org/D71640





More information about the llvm-commits mailing list