[PATCH] D73210: [OPT_DPG][LIVEDEBUGVALUES] Teach Live Debug Values About Meta Instructions

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 09:53:48 PST 2020


dstenb added a comment.

(Just minor comments about tags used in the to-be (?) commit message.)

There is a typo in `[OPT_DPG]`. `OPT[_-]DBG` seems to be uncommon.  I'd personally prefer `[DebugInfo]` as that is an established tag. I'd also prefer writing `LIVEDEBUGVALUES` in camel case instead: `[LiveDebugValues]`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73210/new/

https://reviews.llvm.org/D73210





More information about the llvm-commits mailing list