[PATCH] D73044: {tablegen] Emit string literals instead of char arrays

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 08:57:27 PST 2020


kparzysz added a comment.

There is also the issue of warnings about the size of the generated string.  This would cause `-Werror` builds to fail.

  In file included from /w/src/llvm.org/llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp:44:
  /w/bld/org/lib/Target/X86/X86GenInstrInfo.inc:32952:11: warning: string literal of length 209447 exceeds maximum length 65536 that C++ compilers are required to support [-Woverlength-strings]
    /* 0 */ "G_FLOG10\0"
            ^~~~~~~~~~~~


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73044/new/

https://reviews.llvm.org/D73044





More information about the llvm-commits mailing list