[PATCH] D73260: [Alignement][NFC] Deprecate untyped CreateAlignedLoad

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 04:41:33 PST 2020


gchatelet marked an inline comment as done.
gchatelet added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:1723
+    Builder.CreateAlignedStore(CASExpected, AllocaCASExpected,
+                               AllocaAlignment.value());
     Args.push_back(AllocaCASExpected_i8);
----------------
courbet wrote:
> You don't need the  `.value()` here, there is a `MaybeAlign` overload.
Good catch. I'll do the same kind of patch for `CreateAlignedStore` afterwards to catch them all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73260/new/

https://reviews.llvm.org/D73260





More information about the llvm-commits mailing list