[PATCH] D73179: [IR] masked gather/scatter alignment should be set

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 02:36:03 PST 2020


gchatelet added a comment.

In D73179#1835730 <https://reviews.llvm.org/D73179#1835730>, @delena wrote:

> CreateAlignedLoad allows align 0, as far as I see in the code.
>  We just assume that masked.gather is created from scalar load by vectorizer. Vectorizer just copies alignment from scalar load to masked load/gather and the requirement to alignment should match load alignment.


I see, then you're write that 0 should be allowed.
I'm trying to tighten the alignment type throughout LLVM so I always try to have the most restrictive type.
I'll change the Patch accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73179/new/

https://reviews.llvm.org/D73179





More information about the llvm-commits mailing list