[PATCH] D73255: [ELF][PowerPC] Support R_PPC_COPY and R_PPC64_COPY

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lld/test/ELF/ppc64-reloc-copy.s:1
+# REQUIRES: ppc
+# RUN: llvm-mc -filetype=obj -triple=powerpc64 %p/Inputs/relocation-copy.s -o %t1.o
----------------
Does it make sense to fold this and the other test together? They're practically identical...


================
Comment at: llvm/include/llvm/BinaryFormat/ELFRelocs/PowerPC64.def:29
 #undef R_PPC64_GOT16_HA
 #undef R_PPC64_GLOB_DAT
 #undef R_PPC64_JMP_SLOT
----------------
I think you need an undef here, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73255/new/

https://reviews.llvm.org/D73255