[PATCH] D72992: [llvm-objdump] - Add column headers for relocation printing

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 00:31:04 PST 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/relocations-elf.test:148
+
+## Check relocation formatting on 32 bit as well to verify the padding is correct
+# RUN: yaml2obj --docnum=4 %s > %t4
----------------
liadz0rz wrote:
> grimar wrote:
> > Missing a full stop.
> What's full stop?
The symbol `.` used in writing at the end of a sentence.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72992/new/

https://reviews.llvm.org/D72992





More information about the llvm-commits mailing list