[PATCH] D73107: [llvm-objcopy][COFF] Add support for --set-section-flags

Wed Jan 22 16:37:43 PST 2020

sdmitriev added a comment.

In D73107#1833870 <https://reviews.llvm.org/D73107#1833870>, @mstorsjo wrote:

> In D73107#1833810 <https://reviews.llvm.org/D73107#1833810>, @sdmitriev wrote:
>
> > In D73107#1833352 <https://reviews.llvm.org/D73107#1833352>, @mstorsjo wrote:
> >
> > > Can you check (or did you already?) whether this matches how GNU objcopy behaves (for the cases in GNU objcopy that seem intentional/sensible at least)?
> >
> >
> > Yes, I verified that mingw objcopy produces the same results for all tests from llvm/test/tools/llvm-objcopy/COFF/set-section-flags.test except tests error messages and new "exclude" flag. But I did not check what flags it preserves .
>
>
> Ok - as @MaskRay asked about that, can you test which flags are preserved and which dropped implicitly as well?

As far as I see it does not preserve any flags at all (except alignment flags). Do you suggest to do the same in llvm-objcopy?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73107/new/

https://reviews.llvm.org/D73107