[PATCH] D73234: [gn] Paper over Py3 urllib2 incompatibility in gn/get.py

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 14:34:39 PST 2020


rnk created this revision.
rnk added a reviewer: thakis.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73234

Files:
  llvm/utils/gn/get.py


Index: llvm/utils/gn/get.py
===================================================================
--- llvm/utils/gn/get.py
+++ llvm/utils/gn/get.py
@@ -5,7 +5,11 @@
 
 import io
 import os
-import urllib2
+try:
+    import urllib2
+except ImportError:
+    # Python 3 moved urlopen to urllib.request.
+    import urllib.request as urllib2
 import sys
 import zipfile
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73234.239706.patch
Type: text/x-patch
Size: 367 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200122/b29e3d53/attachment.bin>


More information about the llvm-commits mailing list