[PATCH] D73217: [InlineCost] Add flag to allow changing the default inline cost

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 12:15:05 PST 2020


tejohnson added subscribers: davidxl, mtrofin, tejohnson.
tejohnson added a comment.

@davidxl and @mtrofin for thoughts.

Seems reasonable to decouple the setting of the default from the overriding of the opt size thresholds. However, with your change the only use of InlineThreshold is essentially as a bool flag (was it specified or not). How about leave the InlineThreshold option alone except add a new bool flag to control whether it applies to the opt size thresholds?

Also, needs a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73217/new/

https://reviews.llvm.org/D73217





More information about the llvm-commits mailing list