[PATCH] D73129: [LoopUnrollAndJam] Correctly update LoopInfo when unroll and jam more than 2-levels loop nests.

[Whitney Tsang via Phabricator via llvm-commits]

Whitney marked 2 inline comments as done.
Whitney added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/loopnest.ll:94
+}
+declare void @bar(i64, i64, i64) nounwind readnone
+
----------------
fhahn wrote:
> if that's readnone nounwind and the result is unused, it will just be removed (by simplifyLoopAfterUnroll probably). If you need actual loop body, it's probably better to drop the attributes.
They are required for unroll and jam to be safely performed.  i.e. Without those attributes, unroll and jam is not performed. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73129/new/

https://reviews.llvm.org/D73129