[PATCH] D73159: ARM64: Debug info for structure argument missing DW_AT_location

kamlesh kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 10:51:27 PST 2020


kamleshbhalui marked an inline comment as done.
kamleshbhalui added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp:178
           MRI.replaceRegWith(DstReg, SrcReg);
-          MI.eraseFromParentAndMarkDBGValuesForRemoval();
+          MI.eraseFromParent();
         }
----------------
vsk wrote:
> If MI is erased, why should its debug uses not be made undef? What really causes those debug uses to be updated correctly?
since it is unoptimized it should not mark debug uses as undef.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73159/new/

https://reviews.llvm.org/D73159





More information about the llvm-commits mailing list