[PATCH] D73201: [FPEnv][AArch64] Don't expand STRICT_FP_ROUND to an illegal truncating store

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 11:10:07 PST 2020


kpn added a comment.

In D73201#1834370 <https://reviews.llvm.org/D73201#1834370>, @craig.topper wrote:

> We want to remove all the mutation code once the in tree targets all support STRICT_ nodes properly. It's a hack to enable targets to limp along a little bit, but in hindsight may have been a bad idea since it creates the illusion of things working when they really don't.


It may be worthwhile to remove the mutation code sooner. For ops that are Custom we can't even pretend that things work. And a loud failure up front is better than generating code that silently doesn't do what it was asked to do. Plus, removing the mutation code makes it simpler to read and can avoid confusion from people who haven't been following it for years.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73201/new/

https://reviews.llvm.org/D73201





More information about the llvm-commits mailing list