[PATCH] D73216: [MIPS GlobalISel] Select population count (popcount)

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 10:42:10 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3922
+
+  Register LoIn = MRI.createGenericVirtualRegister(NarrowTy);
+  Register HiIn = MRI.createGenericVirtualRegister(NarrowTy);
----------------
arsenm wrote:
> Assumes NarrowTy == OrigTy / 2. This one should be easy to handle for any divisible type.
Also this won't work for vector


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73216/new/

https://reviews.llvm.org/D73216





More information about the llvm-commits mailing list