[llvm] 1e4764e - Add a comment about when we can remove this construct; NFC.

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 10:17:46 PST 2020


Author: Aaron Ballman
Date: 2020-01-22T13:17:38-05:00
New Revision: 1e4764e1032447d9340468b28cae325385ddcd44

URL: https://github.com/llvm/llvm-project/commit/1e4764e1032447d9340468b28cae325385ddcd44
DIFF: https://github.com/llvm/llvm-project/commit/1e4764e1032447d9340468b28cae325385ddcd44.diff

LOG: Add a comment about when we can remove this construct; NFC.

Added: 
    

Modified: 
    llvm/include/llvm/Support/Compiler.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/Compiler.h b/llvm/include/llvm/Support/Compiler.h
index 6f6f65cad6f5..34d8ed8baf2d 100644
--- a/llvm/include/llvm/Support/Compiler.h
+++ b/llvm/include/llvm/Support/Compiler.h
@@ -95,7 +95,8 @@
 /// Does the compiler support ref-qualifiers for *this?
 ///
 /// Sadly, this is separate from just rvalue reference support because GCC
-/// and MSVC implemented this later than everything else.
+/// and MSVC implemented this later than everything else. This appears to be
+/// corrected in MSVC 2019 but not MSVC 2017.
 #if __has_feature(cxx_rvalue_references) || LLVM_GNUC_PREREQ(4, 8, 1)
 #define LLVM_HAS_RVALUE_REFERENCE_THIS 1
 #else


        


More information about the llvm-commits mailing list