[PATCH] D72829: Implement -fsemantic-interposition

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/IR/GlobalValue.h:287
 
+  bool isDSOPreemptable() const { return !IsDSOLocal; }
+
----------------
MaskRay wrote:
> It seems that this utility is not very necessary.
`isDSOPreemptable` is not used in the new patch. Forgot to remove?


================
Comment at: llvm/include/llvm/IR/Module.h:851
 
+  /// @name Utility functions for querying and setting semantic interposition
+  /// @{
----------------
It does not seem that we use `@{` `@}` nowadays... They don't add much documentation value so they can probably be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72829/new/

https://reviews.llvm.org/D72829