[PATCH] D73070: Add function attribute "patchable-function-prefix" to support -fpatchable-function-entry=N,M where M>0

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 09:55:44 PST 2020


kristof.beyls added a comment.

In D73070#1834196 <https://reviews.llvm.org/D73070#1834196>, @nickdesaulniers wrote:

> I don't mind landing this without aarch64 bti interplay matching GCC precisely; I think it can be done in a follow up.  I just request we don't try to land this in the clang-10 release unless that is also resolved.  Otherwise clang-11.


I think these "patchable function entry" sequences are effectively binary interface, i.e. ABI, as other binary processing tools that use these patchable function entries will make assumptions about the structure of these sequences.
Therefore, I think it's important that clang and gcc do produce the same sequences, otherwise we're causing de-facto ABI incompatibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73070/new/

https://reviews.llvm.org/D73070





More information about the llvm-commits mailing list