[llvm] bfcfa53 - Revert "[gn build] [win] produce symbolized stack frames in release builds too"

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 09:54:41 PST 2020


Author: Nico Weber
Date: 2020-01-22T12:54:19-05:00
New Revision: bfcfa53c3df6857b6bcf4bfa7f811ab84444e6bb

URL: https://github.com/llvm/llvm-project/commit/bfcfa53c3df6857b6bcf4bfa7f811ab84444e6bb
DIFF: https://github.com/llvm/llvm-project/commit/bfcfa53c3df6857b6bcf4bfa7f811ab84444e6bb.diff

LOG: Revert "[gn build] [win] produce symbolized stack frames in release builds too"

This reverts commit fd98eccf984f203e39452da238a142f83f61d368.
Seems to have no effect, need to try it locally for a bit first.

Added: 
    

Modified: 
    llvm/utils/gn/build/BUILD.gn

Removed: 
    


################################################################################
diff  --git a/llvm/utils/gn/build/BUILD.gn b/llvm/utils/gn/build/BUILD.gn
index adb38ec63a4b..b06ef9ad83e3 100644
--- a/llvm/utils/gn/build/BUILD.gn
+++ b/llvm/utils/gn/build/BUILD.gn
@@ -55,13 +55,8 @@ config("compiler_defaults") {
         "/Zi",
         "/FS",
       ]
+      ldflags += [ "/DEBUG" ]
     }
-
-    # Always ask the linker for a pdb. If the .obj files don't contain debug
-    # info, this will produce enough for function names in backtraces, and
-    # it doesn't slow down linking much.
-    ldflags += [ "/DEBUG" ]
-
     if (is_optimized) {
       cflags += [
         "/O2",


        


More information about the llvm-commits mailing list