[PATCH] D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 09:36:47 PST 2020


mstorsjo added inline comments.


================
Comment at: lld/test/COFF/comdat-gcc-compatibility.s:1
+# RUN: llvm-mc %s -triple x86_64-pc-win32 -defsym obj=0 -filetype=obj -o %t1.obj
+# RUN: llvm-mc %s -triple x86_64-pc-win32 -defsym obj=1 -filetype=obj -o %t2.obj
----------------
Sorry I forgot to mention before, this needs a `REQUIRES: x86` line, otherwise it'll fail on builds with the x86 backend disabled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73139/new/

https://reviews.llvm.org/D73139





More information about the llvm-commits mailing list