[PATCH] D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing.

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 08:59:53 PST 2020


hans added a comment.

> IIUC there are multiple ways to fix this:
> 
> 1. Change the operand flags on KILL. It seems like even though `$w8` is marked as renamable we cannot freely rename the result operand. Unless I am missing something, all operands should probably tied.
> 2. Add an additional copy to ensure we actually do the renaming.
> 
>   If marking the operands of KILL as tied makes sense, I think that's what we should go for, as it is more general.

Do you think this fix can happen quickly? Otherwise we'd like to revert this to unbreak the compiler as soon as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70450/new/

https://reviews.llvm.org/D70450





More information about the llvm-commits mailing list