[PATCH] D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic.

Hussain Kadhem via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 08:12:11 PST 2020


hussainjk marked an inline comment as done.
hussainjk added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:887
+  /// return the limit for functions that have OptSize attribute.
+  unsigned getMaxStoresPerMemset(bool OptSize) const;
+
----------------
arsenm wrote:
> hussainjk wrote:
> > arsenm wrote:
> > > Needs an address space
> > The underlying function in TargetLoweringBase -- which this wraps -- doesn't take addressing arguments.
> That's another problem that needs to be solved
I consulted with @Nemanjai on the best way to resolve this; I will be adding address space arguments with default 0 value to the underlying functions in a separate patch after this gets merged, since it's nontrivial and out of scope for this patch (it involves updating function declarations in several different targets at least). I would then add the address space arguments to these new functions in that patch.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70108/new/

https://reviews.llvm.org/D70108





More information about the llvm-commits mailing list