[PATCH] D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Looks good to me, but I'll leave it open for others to comment on still.



================
Comment at: lld/test/COFF/comdat-gcc-compatibility.s:3
+# RUN: llvm-mc %s -triple x86_64-pc-win32 -defsym obj=1 -filetype=obj -o %t2.obj
+# RUN: lld-link /lldmingw /noentry /nodefaultlib /dll %t1.obj %t2.obj /out:%t3.dll
+# RUN: not lld-link /noentry /nodefaultlib /dll %t1.obj %t2.obj /out:%t3.dll
----------------
FYI `/nodefaultlib` isn't strictly needed here, as it only affects cases where the object files have embedded `/defaultlib:` directives.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73139/new/

https://reviews.llvm.org/D73139