[PATCH] D73171: [VE] setcc isel patterns

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:50-58
+def CCUIOp : PatLeaf<(cond), [{
+  switch (N->get()) {
+  default:         return true;
+  case ISD::SETLT:
+  case ISD::SETLE:
+  case ISD::SETGT:
+  case ISD::SETGE: return false;
----------------
You can achieve this with something like:
def COND_OEQ : PatFrags<(ops), [(OtherVT SETOEQ), (OtherVT SETEQ)]>;

which will also work with the GlobalISel emitter


================
Comment at: llvm/test/CodeGen/VE/setcc.ll:11
+; CHECK-NEXT:    or %s11, 0, %s9
+  %3 = fcmp ogt double %0, %1
+  ret i1 %3
----------------
Enumerating all of the compare types is usually helpful


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73171/new/

https://reviews.llvm.org/D73171