[PATCH] D72964: AMDGPU: Fix interaction of tfe and d16

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 22 05:20:16 PST 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:5311
 
-  // Extract the TexFail result and insert into aggregate return
-  SmallVector<SDValue, 1> TFCElt;
-  DAG.ExtractVectorElements(N, TFCElt, DMaskPop, 1);
-  SDValue TFCRes = DAG.getNode(ISD::BITCAST, DL, ResultTypes[1], TFCElt[0]);
-  return DAG.getMergeValues({PreTFCRes, TFCRes, SDValue(Result, 1)}, DL);
+  return DAG.getMergeValues({Data, SDValue(Result, 1)}, DL);
 }
----------------
nhaehnle wrote:
> When does this case actually happen?
This is the normal case with a load. The chainless case is the weird one above for the non-loading intrinsics


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72964/new/

https://reviews.llvm.org/D72964





More information about the llvm-commits mailing list